Pete Zaitcev wrote:
Out of the blue an ALi engineer contacted me and offered a fix for lockups in IBM i-series laptops (RH Bugzilla #50225). I would really appreciate if someone ran it on their _regular_ ohci to ensure that it does not break non-ALi silicon. Both 2.4 and 2.5 are the same (approximately), the patch is against 2.4.
Cool that he did so ... :)
Could you conditionalize this on that particular ALI setup? Two reasons: - such problems are not seen with all other ALI setups, this problem is specific to that i-series configuration or maybe that rev of ALI silicon (looks like it doesn't like to enter the OHCI "suspend" state, it's initting wrong). - this is a blatant spec violation, and I'd rather not require any other OHCIs to accept that specific violation before they can work with Linux. If you'll notice the 2.5 code it comments some different spec violations needed by SiS and OPTi implementations ... I really don't want to see more silicon workarounds get unconditionally put into the init sequence. Haven't tried that patch yet, do you have a 2.5 version? - Dave
@@ -2165,7 +2166,11 @@
/* Reset USB (needed by some controllers) */
writel (0, &ohci->regs->control);
-
+
+ /* Force a state change from USBRESET to USBOPERATIONAL for ALi */
+ (void) readl (&ohci->regs->control); /* PCI posting */
+ writel (ohci->hc_control = OHCI_USB_OPER, &ohci->regs->control);
+
/* HC Reset requires max 10 ms delay */
writel (OHCI_HCR, &ohci->regs->cmdstatus);
while ((readl (&ohci->regs->cmdstatus) & OHCI_HCR) != 0) {
-------------------------------------------------------
This sf.net email is sponsored by: Influence the future of Java(TM) technology. Join the Java Community Process(SM) (JCP(SM)) program now. http://ads.sourceforge.net/cgi-bin/redirect.pl?sunm0002en
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
