On Mon, Oct 21, 2002 at 12:40:21PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Oct 21, 2002 at 08:30:31AM -0700, Greg KH escreveu:
> > On Sat, Oct 19, 2002 at 01:23:44AM -0400, Jack Howarth wrote:
> > > Greg,
> > > Thanks! Regressing out the following patch....
> > >
> > > -----------------------------------------------------------------------
> > > diff -urN linux-2.4.20-pre10/drivers/usb/hid-input.c
>linux-2.4.20-pre11/drivers/usb/hid-input.c
> > > --- linux-2.4.20-pre10/drivers/usb/hid-input.c Sun Nov 11 10:09:37 2001
> > > +++ linux-2.4.20-pre11/drivers/usb/hid-input.c Tue Oct 15 16:49:35 2002
> > > @@ -271,7 +271,7 @@
> > > set_bit(usage->type, input->evbit);
> > >
> > > while (usage->code <= max && test_and_set_bit(usage->code, bit)) {
> > > - usage->code = find_next_zero_bit(bit, max + 1, usage->code);
> > > + usage->code = find_next_zero_bit(bit, usage->code, max + 1);
> > > }
> > >
> > > if (usage->code > max) return;
> > > ------------------------------------------------------------------------
> > >
> > > ...eliminated the kernel hangs on debian ppc sid on my Powermac G4.
> > > Can we get this resolved for 2.4.20pre12?
> >
> > Um, but that fix is needed for some USB mice (or so reported by
> > Arnaldo). Arnaldo, Vojtech, can you take a look at what this is
> > supposed to be?
>
> My fault, I quickly looked this and commited a mistake of reversing it, i.e., I
> thought the parameters were swapped, but in fact it was the right sequence, but
> with this the mouse and keyboard worked, so I'm puzzled, the fix must be elsewhere,
> I'll try to investigate further, but maybe only next week, as this week I'll have
> to go on a business trip.
Greg, please remove Arnaldo's patch for now. Sorry for not checking it
for correctness.
--
Vojtech Pavlik
SuSE Labs
-------------------------------------------------------
This sf.net emial is sponsored by: Influence the future of
Java(TM) technology. Join the Java Community Process(SM) (JCP(SM))
program now. http://ad.doubleclick.net/clk;4699841;7576301;v?
http://www.sun.com/javavote
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
