Hi,
here we go:
vicam_open()
- if you do down_interruptible, you must check for being interrupted
- cam->raw_image = kmalloc(VICAM_MAX_READ_SIZE, GFP_KERNEL);
This allocates 129KB. If possible switch to vmalloc
- initialize_camera(cam);
check the return value. This can fail.
- set_camera_power(cam, 1);
This can fail as well
read_frame()
- request[4] = realShutter & 0xFF;
request[5] = (realShutter >> 8) & 0xFF;
Please use the endianness macros.
vicam_read()
- down_interruptible -> check for being interrupted is missing
vicam_disconnect()
- Frankly, this is utterly broken. Sorry.
vicam_destroy_proc_entry()
- char name[7];
This is too little space. Possible overflow
To the /proc business. This is a kludge. You create a security
hole with that.
Regards
Oliver
-------------------------------------------------------
This sf.net emial is sponsored by: Influence the future of
Java(TM) technology. Join the Java Community Process(SM) (JCP(SM))
program now. http://ad.doubleclick.net/clk;4699841;7576301;v?
http://www.sun.com/javavote
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
