And you should also apply this to some other portions of the code, like usb_submit_urb(), it has extra checks when CONFIG_USB_DEBUG is enabled.
Yes, and I suspect there are a few BUG() or BUG_ON() checks in various drivers that should be #ifdeffed too.
Why make this specific to the core and hcd code, by the way? Surely all drivers should have such a DEBUGGING mode. This isn't "hardening" in the telecoms sense, monitoring for failures/rates/etc, it's just driver debugging support, to make sure the APIs are observed. FWIW I'd rather see something like CONFIG_USB_VERBOSE ... what's today's config menus describe CONFIG_USB_DEBUG ... the real point of that 'hardening' code Where of course the config menus actually set the DEBUG flag, which doesn't IMO match the description. So that might not be practical. - Dave ------------------------------------------------------- This sf.net email is sponsored by: viaVerio will pay you up to $1,000 for every account that you consolidate with us. http://ad.doubleclick.net/clk;4749864;7604308;v? http://www.viaverio.com/consolidator/osdn.cfm _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
