On Sunday 27 October 2002 17:25, Johannes Erdfelt wrote: > > > These loops need timeouts. Suppose I unplugged the USB controller on my > > > cardbus at that moment ? > > > > Then the system will go down! A devil tempts me to point out that it > > would have gone down before this patch as well - look in wakeup_hc a few > > lines below... But you are right of course - I will put in a timeout and, > > sigh, I will audit uhci.c and put in timeouts everywhere else as well. > > I'd be very surprised to see a UHCI cardbus card in the first place, but > it's possible and not very good behaviour so it should be fixed :)
The UHCI card could simply stop working at a bad moment. > FWIW, I think the reason that things worked before this part of the > patch atleast, is because when we set EGSM, we also clear RS at the same > time and it just happens to work on the two common UHCI controllers. It seems to work with mine too for that matter. > But it's not per the spec exactly and should probably do something like > your patch. Now that I see that 2.5 uhci-hcd is based on 2.4 uhci.c (I thought it was based on usb-uhci.c), my plan is to submit patches for 2.5, which can later be backported to 2.4. I can see several ways in which the patches I submitted might be wrong. I also need to do a careful analysis of the locking in uhci-hcd. Ciao, Duncan. PS: All this just to get a cheap controller card working... But every time I think of going and buying a better one, I hear my Scottish ancestors roaring at me! ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
