Hi,
the patch turns it into GFP_ATOMIC.
Question:
if (!urb->status & !acm->throttle) {
...
}
if (acm->throttle) {
...
}
What protects acm->throttle? Can there be data loss?
Regards
Oliver
You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.
===================================================================
[EMAIL PROTECTED], 2002-12-19 01:39:55+01:00, [EMAIL PROTECTED]
- usb_submit_urb() in interrupt must use GFP_ATOMIC
cdc-acm.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -Nru a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
--- a/drivers/usb/class/cdc-acm.c Thu Dec 19 01:44:53 2002
+++ b/drivers/usb/class/cdc-acm.c Thu Dec 19 01:44:53 2002
@@ -278,7 +278,7 @@
urb->actual_length = 0;
urb->dev = acm->dev;
- if (usb_submit_urb(urb, GFP_KERNEL))
+ if (usb_submit_urb(urb, GFP_ATOMIC))
dbg("failed resubmitting read urb");
}
===================================================================
This BitKeeper patch contains the following changesets:
1.1123
## Wrapped with gzip_uu ##
begin 664 bkpatch9957
M'XL(`(46`3X``\546V^;,!1^CG_%D?K2J`-\P=PDIG3IUE7;U"A;GR-LW(`2
M0F7#+A(_?@:D9(VBJ.L>9AV#.<?G\)W/GWP!#T;I9%)OR^]*HPOX6)O&?JI=
MO5-N45=J6^[:GVZMUS:XK&L;]'JW-V9X8N,T6BGCM490CNRF1=;(`FS,)!/B
MLKVG^?6DDLGR_>W#Y^LE0FD*\R+;K=57U4":(K&9Y:W:NAM=9T7_OVX?[BC&
MA!#*,>,!X1V-&/,[$F"1VV5.P_A1!#%::[6>C>FRKIZG4T))V#\YZWP>TQC=
M`'%M30:8>L1:#)@D+$XXO[(+C&%L<':*"K@BX&#T#OX=]!Q)<,"2MS*MJ,IF
MU6IQ.85R9ZU16K=/#52M:>P6!;<?%JOK;_=?[N;H$_@A(P%:'%A$SE\.A'"&
MT=L37>2Z[WTX5"^3E2L/W?@X)D%'61"R3O@^9:%@44X%SQ0]Q]FSFG*;&>/)
M7#K[ZOT)Q1BS"`<=IY3Z@T3.))T6S2N1'XOG!6"QA<MP/("-!CFQ(S%%"0Y>
M*";RG\4T,GX/COXQF!7'XASYK]#:#8T($'0WOB;E(UP>(;7SS1^PIM/#=2(+
4)3>FK5*%1>"3G*'?FY!#'KH$````
`
end
-------------------------------------------------------
This SF.NET email is sponsored by: Order your Holiday Geek Presents Now!
Green Lasers, Hip Geek T-Shirts, Remote Control Tanks, Caffeinated Soap,
MP3 Players, XBox Games, Flying Saucers, WebCams, Smart Putty.
T H I N K G E E K . C O M http://www.thinkgeek.com/sf/
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
