Am Dienstag, 28. Januar 2003 13:54 schrieb Oliver Kurth:
> Hello!
>
> I wrote a new driver for Atmel at76c503 based USB wlan adapters. See
> the link below in my .signature.

What's wrong with the existing driver?

> Maybe someone wants to look over it. It is still in development,
> and supports only ad-hoc mode at the moment. There is one 'exotic'
> thing about it: it uses another module which I wrote to load the
> firmware, it is included in the package. It works as follows:

        block = kmalloc(EXT_FW_BLOCK_SIZE, GFP_KERNEL|GFP_DMA);
        if(block == NULL) return -ENOMEM;

Wrong. Use GFP_KERNEL only.

        if(urb->status != 0){
                if((urb->status != -ENOENT) &&
                   (urb->status != -ECONNRESET)) {
                        dbg(__FUNCTION__ " - nonzero write bulk status received: %d",
                            urb->status);
                }
                return;

Any error will lock up the device? Not nice.

        struct ieee802_11_hdr *i802_11_hdr =
                (struct ieee802_11_hdr *)&(tx_buffer->packet);

        down(&dev->sem);
down() with spinlock held. Absolute taboo. There are severaly bugs
of this kind.

        HTH
                Oliver



-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to