The usb_snddefctrl and usb_rcvdefctrl macros are wrong. This hasn't shown up until now because usb_rcvdefctrl isn't used anywhere at all, and usb_snddefctrl is used exactly once (in core/usb.c).
This patch fixes the macros. It would be just as reasonable to remove them entirely and change the one use -- take your choice. Alan Stern ===== usb-2.5/include/linux/usb.h 1.128 vs edited ===== --- 1.128/include/linux/usb.h Tue Feb 18 19:18:58 2003 +++ edited/usb-2.5/include/linux/usb.h Mon Feb 24 10:19:25 2003 @@ -960,8 +960,8 @@ #define usb_rcvbulkpipe(dev,endpoint) ((PIPE_BULK << 30) | __create_pipe(dev,endpoint) | USB_DIR_IN) #define usb_sndintpipe(dev,endpoint) ((PIPE_INTERRUPT << 30) | __create_pipe(dev,endpoint)) #define usb_rcvintpipe(dev,endpoint) ((PIPE_INTERRUPT << 30) | __create_pipe(dev,endpoint) | USB_DIR_IN) -#define usb_snddefctrl(dev) ((PIPE_CONTROL << 30)) -#define usb_rcvdefctrl(dev) ((PIPE_CONTROL << 30) | USB_DIR_IN) +#define usb_snddefctrl(dev) ((PIPE_CONTROL << 30) | __create_pipe(dev,0)) +#define usb_rcvdefctrl(dev) ((PIPE_CONTROL << 30) | __create_pipe(dev,0) | USB_DIR_IN) /* -------------------------------------------------------------------------- */ ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
