On Fri, Mar 14, 2003 at 03:48:24AM +0100, Oliver Neukum wrote: > Hi Greg, > > you recently asked whether the module pointers could be removed. > I looked at the question and the answers is that they cannot be removed. > The ioctl into the driver through usbfs makes that impossible.
Ah crap, I hate that ioctl! Only one driver has ever used it, the hub driver. Hm... Ah, in looking both at the libusb code, and usbutils (lsusb and friends), they do not actually use the USBDEVFS_HUB_PORTINFO ioctl call into usbfs (which calls the hub driver's ioctl call.) So, any complaints if I get rid of the hub_ioctl() call in hub.c? That way we can drop the ioctl field in the usb_driver structure, and the logic in devio.c to call the ioctl (which is some heavily locking code). And then, it looks like we could drop the struct module * also in the usb_driver, as we are protected by the driver core during the other calls into the usb driver, right? (Unless I ever prove a need for using the module reference count in a urb :) Anyway, I want to drop that ioctl field, any objections? Anyone actually using this code anywhere? thanks, greg k-h ------------------------------------------------------- This SF.net email is sponsored by:Crypto Challenge is now open! Get cracking and register here for some mind boggling fun and the chance of winning an Apple iPod: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
