ChangeSet 1.1094.6.8, 2003/03/14 10:43:24-08:00, [EMAIL PROTECTED]

[PATCH] Memleak in KOBIL USB Smart Card Terminal Driver

   There is a memleak on error exit path in KOBIL USB Smart Card Terminal
   Driver in both current 2.4 and 2.5.
   See the patch.
   Found with help of smatch + enhanced unfree script.


 drivers/usb/serial/kobil_sct.c |    2 ++
 1 files changed, 2 insertions(+)


diff -Nru a/drivers/usb/serial/kobil_sct.c b/drivers/usb/serial/kobil_sct.c
--- a/drivers/usb/serial/kobil_sct.c    Mon Mar 17 11:46:43 2003
+++ b/drivers/usb/serial/kobil_sct.c    Mon Mar 17 11:46:43 2003
@@ -253,6 +253,7 @@
                port->write_urb = usb_alloc_urb(0, GFP_KERNEL);  
                if (!port->write_urb) {
                        dbg("%s - port %d usb_alloc_urb failed", __FUNCTION__, 
port->number);
+                       kfree(transfer_buffer);
                        return -1;
                }
        }
@@ -260,6 +261,7 @@
        // allocate memory for write_urb transfer buffer
        port->write_urb->transfer_buffer = (unsigned char *) 
kmalloc(write_urb_transfer_buffer_length, GFP_KERNEL);
        if (! port->write_urb->transfer_buffer) {
+               kfree(transfer_buffer);
                return -1;
        } 
 



-------------------------------------------------------
This SF.net email is sponsored by:Crypto Challenge is now open! 
Get cracking and register here for some mind boggling fun and 
the chance of winning an Apple iPod:
http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to