I'm pretty much with Alan on this one. My personal style thinks that you should log a message on entry to the function, log a different message if there is more than 1 interface, and log a message with the result code if the reset performed.
Other than that, it looks good.
Matt
On Sat, Mar 22, 2003 at 03:41:28PM -0500, Alan Stern wrote:
> On Sat, 22 Mar 2003, Oliver Neukum wrote:
>
> > OK, as the consensus seems to be that in the short run changing things
> > for a full reset implementation is not worth it, here's an implementation
> > that does the best we can do without.
> > It issues a reset only if we can be sure that there are no other users
> > of the device in question.
> > As the version currently in the storage driver is broken anyway,
> > this is a definite improvement. And it addresses the need of exporting
> > the probe/remove functions for storage's sake.
>
> The patch looks good. I would just add a warning log message to the path
> where there's more than 1 interface.
>
> Alan Stern
--
Matthew Dharm Home: [EMAIL PROTECTED]
Maintainer, Linux USB Mass Storage Driver
Da. Am thinkink of carbonated borscht for lonk nights of coding.
-- Pitr
User Friendly, 7/24/1998
pgp00000.pgp
Description: PGP signature
