Greg, please apply this to the 2.4 tree. Matt
----- Forwarded message from Alan Stern <[EMAIL PROTECTED]> -----
Date: Sat, 22 Mar 2003 17:06:11 -0500 (EST)
From: Alan Stern <[EMAIL PROTECTED]>
Subject: Re: [linux-usb-devel] Belkin Compact Flash card reader
To: Matthew Dharm <[EMAIL PROTECTED]>
cc: USB Storage List <[EMAIL PROTECTED]>
X-Spam-Status: No, hits=-9.0 required=5.0 tests=IN_REP_TO,UNIFIED_PATCH,RCVD_IN_ORBZ
version=2.11
On Sat, 22 Mar 2003, Matthew Dharm wrote:
> I have it, I think... better resend to make certain.
See below.
> It should probably be part of 2.5 also, but I was hoping to hear from JE
> first about the odd looking code in UHCI.
I think 2.5 doesn't need it; the odd code in question was moved from uhci
into the upper hcd layer and fixed (or removed) along the way. But I
don't have the source here so I can't be sure about that. It certainly
seems strange, though -- without this change the driver would fail
everything once an abort occurred on a uhci host.
Alan Stern
--- 2.4.21-pre5/drivers/usb/storage/transport.c.orig Sat Mar 22 16:58:53 2003
+++ 2.4.21-pre5/drivers/usb/storage/transport.c Sat Mar 22 16:59:36 2003
@@ -388,6 +388,7 @@
us->current_urb->actual_length = 0;
us->current_urb->error_count = 0;
us->current_urb->transfer_flags = USB_ASYNC_UNLINK;
+ us->current_urb->status = 0;
/* submit the URB */
status = usb_submit_urb(us->current_urb);
@@ -434,6 +435,7 @@
us->current_urb->actual_length = 0;
us->current_urb->error_count = 0;
us->current_urb->transfer_flags = USB_ASYNC_UNLINK;
+ us->current_urb->status = 0;
/* submit the URB */
status = usb_submit_urb(us->current_urb);
----- End forwarded message -----
--
Matthew Dharm Home: [EMAIL PROTECTED]
Maintainer, Linux USB Mass Storage Driver
E: You run this ship with Windows?! YOU IDIOT!
L: Give me a break, it came bundled with the computer!
-- ESR and Lan Solaris
User Friendly, 12/8/1998
pgp00000.pgp
Description: PGP signature
