[linux-usb-devel] Re: 2.5.65 hard hang with usb kvm switch disconnect...

[David Brownell]

Nathan Laredo wrote:

I just installed 2.5.65, and when I switch my USB kvm switch away from my
linux box, i get the following:
"ohci-hcd 00:03.0: dev 2.1 ep1-in linked; disconnect() bug?"

p5.patch cured this.  Thanks!
Thanks for the update ... I wonder what other drivers are getting
indigestion when their disconnect() routines aren't allowed to
do anything?  :)
CC'd to the linux-usb developer list, in case others have similar
kinds of problems.
- Dave


--- 1.15/drivers/usb/core/urb.c Thu Mar 13 10:45:40 2003
+++ edited/drivers/usb/core/urb.c       Thu Mar 20 11:17:55 2003
@@ -384,11 +384,11 @@
        /* FIXME
         * We should not care about the state here, but the host controllers
         * die a horrible death if we unlink a urb for a device that has been
-        * physically removed.
+        * physically removed.  (after driver->disconnect returns...)
         */
        if (urb &&
            urb->dev &&
-           (urb->dev->state >= USB_STATE_DEFAULT) &&
+           // (urb->dev->state >= USB_STATE_DEFAULT) &&
            urb->dev->bus &&
            urb->dev->bus->op)
                return urb->dev->bus->op->unlink_urb(urb);