-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Wed, 26 Mar 2003 01:41, Benjamin Herrenschmidt wrote:
> This code in cdc-ether.c, CDCEther_start_xmit()
> 2.5.x current but 2.4 seem wrong too:
>
> // If we are told to transmit an ethernet frame that fits EXACTLY
> // into an integer number of USB packets, we force it to send one
> // more byte so the device will get a runt USB packet signalling the
> // end of the ethernet frame
> if ( (skb->len) ^ (ether_dev->data_ep_out_size) ) {
> // It was not an exact multiple
> // no need to add anything extra
> count = skb->len;
> } else {
> // Add one to make it NOT an exact multiple
> count = skb->len + 1;
> }
>
> Shoudn't it be skb->len % ether_dev->data_ep_out_size instead ?
Yes, although I sent a patch (that I'd been trying to get people to provide
test feedback on for months - I never saw the problem occur on my test setup)
to the l-u-devel mailing list that corrects this (a few days ago).
Are you actually seeing problems? Can you test the patches?
Brad
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE+gLE/W6pHgIdAuOMRAjQ8AJ9nFPA3Gket/sGtUWvqfH5K9Dzo7gCfaTmU
wf0Lh8iq3+WoyziRXNP9gbs=
=g3MB
-----END PGP SIGNATURE-----
-------------------------------------------------------
This SF.net email is sponsored by:
The Definitive IT and Networking Event. Be There!
NetWorld+Interop Las Vegas 2003 -- Register today!
http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
