On Mon, 9 Jun 2003, David Brownell wrote:

> You don't need to keep the URB_NO_DMA_MAP bitmask around;
> it'll be clearer to delete it.  And I must have missed the
> code in usb_buffer_{map,dmasync,unmap}() for setup buffers;
> unless you meant to not include that?  (OK, just quirky.)

The only reason I kept URB_NO_DMA_MAP was to avoid the need for updating
multiple drivers that already use it.  However, if you think we're better
off without it, I'll take it out and change the drivers.

I did not put anything in usb_buffer_map etc. to handle the setup buffers,
partly because I was trying to stick to the existing functionality as much
as possible, and partly because I didn't think of it :-)  Now that you
bring it up, though, it does make sense to set up a streaming map for the
setup buffer as well.  There will have to be a requirement that the setup
buffer _not_ be mapped beforehand, but that shouldn't hurt -- especially
since no drivers currently use usb_buffer_map()!

Alan Stern



-------------------------------------------------------
This SF.net email is sponsored by:  Etnus, makers of TotalView, The best
thread debugger on the planet. Designed with thread debugging features
you've never dreamed of, try TotalView 6 free at www.etnus.com.
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to