Hi,
Ok, I have get rid of the typedefs and make it build on 2.4.21.
I'm not try to merge this with the existing sl811 driver, I modifed most of it for
support isochronous transfer mode, especially the structrue and the urb schedule part,
so it's almost a new one. Some one need this feature can use this one, others can
still use the existing. So may be it makes sense to have two different drivers.
Note: I wrote it on 2.4.18, at our board which use SA1110, and I test it with usb
mouse, usb moving disk and a web camera which use ov511 chipset.
Thanks for suggest,yah ----- Original Message ----- From: "Greg KH" <[EMAIL PROTECTED]> To: "yah" <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Sent: Wednesday, July 09, 2003 11:14 AM Subject: Re: patch for sl811 usb host controller driver > On Wed, Jul 09, 2003 at 10:10:06AM +0800, yah wrote: > > Hi, > > The Original driver by cypress for sl811 host does't support > > isochronous device, so when i try to make it work with ov511, i mostly > > rewrite it, now it support isochronous and more effective. This driver > > is write at 2.4.18, and should work for all 2.4.xx. Is this one will > > be some useful for others? > > Is there any way you can merge this with the existing sl811 driver? Or > are the changes so that it makes sense to have two different drivers? > > Also this will not build on 2.4.21, as there is no more urb_t typedef. > Can you fix this please? > > > This is the first time i submit a patch, what i do is right? > > It looks great, thanks. Only minor thing I would suggest is to get rid > of the other typedefs that you have added. Stick with just using > "struct ..." as that is the proper kernel programming style. > > Clean that up, and I don't see any reason not to add it, nice job. > > thanks, > > greg k-h
patch-2.4.21-sl811
Description: Binary data
