Hello!

Linux 2.6.0-test1 oopses every time when pilot-link finished upload.  I'm
using the Visor driver and devfs.  Linux .config and the exact oops output
can be found here: http://www.red-bean.com/~proski/visor/

destroy_serial() in drivers/usb/serial/usb-serial.c checks if port->tty
and tried to access port->tty->driver_data, which is invalid.

Since serial_open() assigns a value to port->tty, I guess serial_close()
should set it back to NULL.  Indeed, this patch fixes the oops for me:

====================================
--- linux.orig/drivers/usb/serial/usb-serial.c
+++ linux/drivers/usb/serial/usb-serial.c
@@ -531,6 +531,8 @@ static void serial_close(struct tty_stru
        if (tty && tty->driver_data) {
                __serial_close(port, filp);
        }
+
+       port->tty = NULL;
 }

 static int serial_write (struct tty_struct * tty, int from_user, const unsigned char 
*buf, int count)
====================================

-- 
Regards,
Pavel Roskin



-------------------------------------------------------
This SF.net email is sponsored by: VM Ware
With VMware you can run multiple operating systems on a single machine.
WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines at the
same time. Free trial click here: http://www.vmware.com/wl/offer/345/0
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to