On Tue, Jul 22, 2003, Alan Stern <[EMAIL PROTECTED]> wrote: > The current implementation of the Change-Port-Reset bits for the root hub > in uhci-hub.c is totally bogus. This patch fixes it. > > Of course, it's not really necessary to implement those bits at all -- the > UHCI driver works fine right now with a broken implementation. Maybe you > would prefer to remove the support entirely. But if you want to keep it > and the patch looks good, please ask Greg to apply it.
It probably is a good idea to fix it. I want to take a look at the problem a little closer, but I agree there is a problem. I only have one question about the implementation. > + /* Convert wIndex to origin 0; if it was 0, it will wrap around */ > + --wIndex; We should probably do sanity checking on wIndex in more places. A malformed control message can probably cause an oops. JE ------------------------------------------------------- This SF.net email is sponsored by: VM Ware With VMware you can run multiple operating systems on a single machine. WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines at the same time. Free trial click here: http://www.vmware.com/wl/offer/345/0 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
