P.S.: While we're on the subject of renaming functions, the most egregious example I know of in usbcore is usb_connect(). This function does nothing more than select a new, unused USB address. It ought to be called usb_choose_address(), parallel to usb_set_address(). That wouldn't be a big change, since the function is called in only one place. Shall I fold that into the patch as well?

Fine by me -- except it's not quite called in just one place, the HCD root hub init code calls it to pick address 1 (duh!), and that seems like something the generic root hub init code should be doing.

There's no point in even exporting this one.

- Dave






------------------------------------------------------- This SF.net email is sponsored by: VM Ware With VMware you can run multiple operating systems on a single machine. WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines at the same time. Free trial click here: http://www.vmware.com/wl/offer/345/0 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to