On Thu, 24 Jul 2003, David Brownell wrote: > Alan Stern wrote: > > > > If David agrees, this is ready to be applied. > > Looks fine to me except that register_root_hub() shouldn't > set a potentially bogus (at high speed) bMaxPacketSize0: > > > + usb_dev->descriptor.bMaxPacketSize0 = 8; > > 64 is legal for both full and high speed root hubs. (There's > no such thing as a low speed one...) > > This is a nit, since nobody should really care about the value, > but if you're going to set it at all it shouldn't be illegal. > > Thanks for cleaning this bit up!
I just copied the code from the original usb_connect() routine. If the value really isn't needed, that line could be removed (it's also in the hc_simple driver). Or the value could be changed to 64. But doesn't there have to be _something_ there so that URBs won't fail the bogus-maxpacket check in usb_submit_urb()? Alan Stern ------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
