On Mon, Jul 21, 2003 at 09:47:30AM -0400, Alan Stern wrote:
> David:
> 
> The recent change you made to the irq handling in hcd_endpoint_disable() 
> caused a problem.  The statement
> 
>       local_irq_save (flags);
> 
> needs to be outside the rescan loop.  Otherwise, on loop iterations after 
> the first, flags is always set to indicate that interrupts are disabled.
> 
> In fact, since the routine ends with might_sleep() anyway, I don't see any
> reason to save the interrupt state at all.  My patch just disables
> interrupts at the start and enables them at the end.  I'm not sure that's
> how you intended it to work, so you may want to change it a little.

Applied, thanks.

greg k-h


-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to