On Mon, Jul 28, 2003 at 05:08:29PM -0400, Alan Stern wrote:
> On Mon, 28 Jul 2003, David Brownell wrote:
>
> > Alan Stern wrote:
> > > David:
> > >
> > > This revised patch implements the approach you described.
> > > usb_set_interface() is changed to work even with devices that have only
> > > one altsetting, and it gets called after unbinding a driver. There are
> > > several other small changes, including a spot in usb_set_configuration()
> > > where all the interfaces are marked as being in altsetting 0 -- an obvious
> > > fact that was unaccountably missing. Take a look and see what you think.
> >
> > Reads clean. Though I might document the changed calling context
> > requirement for usb_release_interface(), and it might be good to
> > add an alternate path in usb_disable_endpoint() for "old-style"
> > HCDs, which at least clears maxpacket.
>
> Those are two good suggestions. I had intended to implement that
> alternate path, but it slipped my mind -- thanks for pointing it out.
> Here's the revised patch (as66c).
I like this patch, but:
- it does too much all at once. Can you split it up into the
different pieces?
- it doesn't apply to my tree due to some changes I've had to
make to the interface structure to fix a kobject memory leak
bug.
Can you re-diff it and split it up?
thanks,
greg k-h
-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
