Hi,
there are a few things to clean up
1. usb_submit_urb called from a completion handler must use GFP_ATOMIC
2. you should also check for ESHUTDOWN if you check for ENOENT
3. you cannot blink an LED with usb_ctrl_msg from a completion handler,
as it sleeps, this needs schedule_work. Is it worth the effort?
Regards
Oliver
You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.
===================================================================
[EMAIL PROTECTED], 2003-08-06 15:19:37+02:00, [EMAIL PROTECTED]
- fix several instances of sleeping in interrupt and error checks
st5481_b.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff -Nru a/drivers/isdn/hisax/st5481_b.c b/drivers/isdn/hisax/st5481_b.c
--- a/drivers/isdn/hisax/st5481_b.c Wed Aug 6 15:20:34 2003
+++ b/drivers/isdn/hisax/st5481_b.c Wed Aug 6 15:20:34 2003
@@ -110,7 +110,7 @@
DBG_ISO_PACKET(0x200,urb);
- SUBMIT_URB(urb, GFP_KERNEL);
+ SUBMIT_URB(urb, GFP_ATOMIC);
}
/*
@@ -163,7 +163,7 @@
test_and_clear_bit(buf_nr, &b_out->busy);
if (urb->status < 0) {
- if (urb->status != -ENOENT) {
+ if (urb->status != -ENOENT && urb->status != -ESHUTDOWN) {
WARN("urb status %d",urb->status);
if (b_out->busy == 0) {
st5481_usb_pipe_reset(adapter, (bcs->channel+1)*2 |
USB_DIR_OUT, NULL, NULL);
@@ -176,8 +176,8 @@
usb_b_out(bcs,buf_nr);
- if (adapter->number_of_leds == 2)
- led_blink(adapter);
+// if (adapter->number_of_leds == 2)
+// led_blink(adapter);
}
/*
===================================================================
This BitKeeper patch contains the following changesets:
1.2153
## Wrapped with gzip_uu ##
begin 664 bkpatch25349
M'XL(`*,`,3\``ZV464_;0!"`G[V_8BHD5$1M[_JVJR".I(`*)`J)^ACYV,16
M?$2[-J6J?WS'[EMAIL PROTECTED])266BOMV'/L')]W#^:2BT"I\NR."[('%Y6L`P7EHDEX
MJ96\63>%5HD5ZJ95A3H]K0JN;QWTF>!<ZHV,5$.S"=I,PCI.`54R4)AF/GRI
MOVUXH$Q'[EMAIL PROTECTED]&<I6&YXK>\AL&`1.OCI.&YMA95F';'M0_JUJ"4,6;8
MU+0=9K>&9YI6RQP:)[EMAIL PROTECTED](\<GVX2.=V3^-)1)/6HQE_G,;QW#MPTR!*89
MS#:!FCKU=.H`LP/F!Z9[2(V`4OA]:#ADH%)R"F_/_XS$H,(RNP?)\:0PAZR4
M=5C&7$*U!)ESOLG*%7[%57,AFDT-89D`BI6`..7Q6I+/X%B&99')8WN)^I</
M(32DY&A'38GH&B'U3":EGF8RO-=E;5L>6T1:_%BG17V*%:+DM%[LN#2*X\AU
M+-^R7NCEGZ-WHW.8R7S3;*G);*OGZ$6WW6R]O0ZR$GQUO(T85\5K<F<8S4$"
MW)92C]$>._8<.O,[EMAIL PROTECTED]/\T69S,QM>79T\(Z_4]6[!$RIIRDS>K
MCL<4[PF(J[(659YS`:&$$`0/957VECV5LG=/L!U1SB'*LW+=(7PU&LK.(:NA
MX&$I=\.-+/<S'H,JOO8+T9R\/.Y_8'W(<`B,7&XWY79^>GTY6\RGI^\;$7WX
MI2\'']'6<7K;?E.4;`F=E7J$/VK=2'@W`'5T,Q[=S&!_'YYI;B_FL^'XR\T!
M?,[EMAIL PROTECTED]&AO(H;KK>QPJ3<(/5JT=E4T1<+*KE(N>)1(C!..B,%'Q=]'W\:8M9
8/[EMAIL PROTECTED];,8H:?>!'Y`:MU&:3?!0``
`
end
-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
