Am Donnerstag, 14. August 2003 22:28 schrieb David Brownell:
> Oliver Neukum wrote:
> > Am Samstag, 9. August 2003 02:04 schrieb David Brownell:
> >
> >>The code that manges the synchronous control/bulk calls has
> >>been a mess for ages. This patch rewrites it using:
> >>
> >> - "struct completion" instead of a usb-internal clone therof,
> >> - prepare_to_wait()/finish_wait() instead of the tangled
> >> mess it now uses (or a new wait_event_timeout call, as in
> >> previous versions of this patch).
> >
> >
> > If you don't want wait_event_timeout, it seems to me that only
> > struct completion should be used like this:
>
> How about making it even simpler, and replacing that useless
> diagnostic with one that might help troubleshooting? :)
>
> This is an even simpler rewrite, which doesn't lay any kind
> of groundwork for interruptible synchronous calls. (I still
> think we should have that, but this patch seems ready to go
> the next time Greg merges patches...)
This seems nearly perfect to me and should be merged.
might_sleep() isn't needed because wait_for_completion()
has it.
Regards
Oliver
-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
