This patch adds support for the ASIX AX8817x based ethernet devices to the usbnet driver (deprecating the current ax8817x driver). At this point, I consider it highly experimental, don't deploy in production, etc etc etc. It is in the "works for me" category and I seem to get pretty decent transfer speeds out of it (on some occassions, even better than the existing ax8817x driver). I see this driver being the long-term for ax8817x support in that it makes use of all of the plumbing already provided by usbnet and gives us a net loss of about 1000 lines of code.
As you know, I think this is a good approach ... we can start saving a thousand lines of "framework" code from other network adapters too! But no rush on that. :)
+#define FLAG_FRAMING_ASIX 0x0008 /* AX8817x URB sizing */
Is that sizing ... or framing? Seems like rx wants an extra two bytes, but it's not clear exactly why. Having the RX urbs be larger will usually be a fine thing (not AX88117x-specific), coping with various hardware/firmware quirks: "be lenient in what you accept".
+ if (dev->mii.mdio_read != NULL && dev->mii.mdio_write != NULL) + return generic_mii_ioctl(&dev->mii, (struct mii_ioctl_data *) &rq->ifr_data, cmd, NULL);
Can the MII stuff all be made conditional? If no configured "minidriver" needs it, the kernel shouldn't require that additional code. (In the same way, only the Zaurus minidriver really needs the CRC module. That predates the per-minidriver config options, and hasn't yet been fixed.)
+
+#ifdef CONFIG_USB_AX8817X
+ urb->transfer_flags |= URB_ZERO_PACKET;
+#endif
/* don't assume the hardware handles USB_ZERO_PACKET
This should be testing for FLAG_FRAMING_ASIX on the specific device, too; the same driver core code can be used with several devices, each with different framing. But why is the TX framing different from the RX framing?
- Dave
------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
