On Fri, Aug 22, 2003 at 10:42:01AM -0400, Alan Stern wrote: > On Thu, 21 Aug 2003, Greg KH wrote: > > > Does this actually catch anything new? And based on your other email > > messages, I think it's a bit wrong :) > > > > Also, don't fix up improper urbs, if the submitter gets it wrong, it's > > wrong, they should fix their code. > > Good points. Here is a revised version (as85b). In more detail, this > patch does three things: > > When a device is not in the CONFIGURED state, it disallows > transfers to any endpoint other than ep0 (currently the code allows > transfers to any control endpoint).
Again, what is this going to help? Improperly written drivers? > For control transfers, it verifies that the direction given by the > pipe is the same as the direction indicated in the setup packet (but only > if the transfer length is > 0). Why? Bad drivers? > For isochronous transfers, it verifies that none of the iso. frame > descriptors refers to an offset that is outside the transfer buffer. It > also initializes the error_count field to 0 so the HCD doesn't have to. Does this save code in the hcd core? > So far as I know, there aren't any existing errors this patch will detect. > (For that matter, I don't know that _any_ of the checks in > usb_submit_urb() detects an existing error.) It's intended as a defensive > measure -- as long as we're checking things, we might as well be thorough. Yeah, but adding pointless checks aren't good either :) So I'll hold of on this for now, sorry. greg k-h ------------------------------------------------------- This SF.net email is sponsored by: VM Ware With VMware you can run multiple operating systems on a single machine. WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines at the same time. Free trial click here:http://www.vmware.com/wl/offer/358/0 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
