On Mon, Aug 25, 2003 at 03:32:24PM -0400, Stuart MacDonald wrote:
> There's a problem with multiple White Heats in one system; the
> firmware fake devices each suck up a minor number, and when the real
> devices start enumerating they start at the first free number. The
> user-visible symptom is that sometimes (on a warm reboot the firmware
> is already running, and the fake devices are never seen) the White
> Heats will start at 0, and sometimes will start at a higher number,
> even though there's space and nothing else taking the lower numbers.
> 
> This patch fixes this behaviour, by copying the good-but-skip-init
> behaviour used by the type->attach code into the type->probe code.
> 
> I don't see a problem, and testing of the 2.4 kernels has worked for
> us, but I currently don't have a system that will build the 2.6 test
> kernels so this *specific* patch is untested.

Heh, the whiteheat device doesn't even work on 2.6 right now due to a
sysfs bug.  This prevents all firmware-download devices from running, so
I can't test this.  Pat Mochel said he would look into that bug sometime
next week.

> Greg, please apply.

I'll wait till I can test this before applying it, is that ok?

There are also lots of other bugs in the White Heat driver in 2.6.  If
you go back to 2.6.0-test3 and run the device on a SMP kernel with
pre-empt enabled and spinlock debugging enabled, you will see lots of
errors in the kernel log.  Want to fix those up?

> I'll apologise ahead of time for any tab damage; we switched from OE
> to Outlook, and my test shows tabs are honoured now, but this will be
> my first patch posted.

It was line wrapped :(

But the tabs came through :)

thanks,

greg k-h


-------------------------------------------------------
This SF.net email is sponsored by: VM Ware
With VMware you can run multiple operating systems on a single machine.
WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines
at the same time. Free trial click here:http://www.vmware.com/wl/offer/358/0
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to