On Tue, Sep 16, 2003 at 11:28:22AM -0700, Greg KH wrote: > On Wed, Sep 10, 2003 at 12:46:09PM -0700, David Brownell wrote: > > [ once more, with patch! ] > > > > I just noticed that Linus' tree is using the wrong CONFIG_* symbols > > for kicking in the PXA 2xx support (except for "gadgetfs"). It > > should use USB_PXA2XX not USB_PXA250, since it handles PXA 255, > > PXA 210, PXA 263, and others. > > > > Please merge to Linus' tree. Russell, if you include the PXA > > UDC code in your upcoming -test5-rmk1 patch, you should also > > include this. > > Applied, thanks.
I provided some feedback to David today, so it might be an idea to hold back on integrating it until David has had a chance to respond to this. - - - Submitted by Russell King on 16 Sep 2003 17:06:20 (UTC) - - - Well, asm/proc/cache.h is gone in 2.6, so this doesn't compile. I've also been wondering why you want to include this file - nothing should include asm/proc/*.h directly unless they have an extremely good reason. Then I found this: + clean_dcache_range(start, start + _req->length); which is an abuse of the macro: /* * Perform necessary cache operations to ensure that the TLB will * see data written in the specified area. */ #define clean_dcache_area(start,size) cpu_dcache_clean_area(start, size) since you're not using it to ensure we have TLB consistency. It looks like you really want to be using the DMA API here. I'm also slightly concerned about the got_irq ... req_config bitfields - req_* seem to be interrupt context stuff (can they be process context as well?), where as the others seem to be process context - and I don't see any locking. -- Russell King ([EMAIL PROTECTED]) http://www.arm.linux.org.uk/personal/ Linux kernel maintainer of: 2.6 ARM Linux - http://www.arm.linux.org.uk/ 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
