On Mon, Sep 22, 2003 at 08:49:30AM -0700, Patrick Mansfield wrote: > On Mon, Sep 22, 2003 at 04:11:04PM +0100, Christoph Hellwig wrote: > > On Mon, Sep 22, 2003 at 03:31:24PM +0100, Christoph Hellwig wrote: > > > Patch looks mostly fine to me, but please all flags should be unsigned instead > > > of signed and scsi_devinfo.h needs some inclusion guards. > > > > Actually I think it could be made much simpler by killing the per-template > > bflags and just setting the scsi_device flags from slave_alloc or > > slave_configure. Could you cook up a patch like that? > > You mean add the flags to scsi_device rather than scsi_host? > And allow setting the sdev->flags only in slave_alloc.
What I meant is not adding a blist flags member at all but rather setting skip_ms_page_8 and skip_ms_page_3f from ->slave_alloc. But I probably missed something obvious :) ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
