On Wed, Sep 24, 2003 at 03:17:36PM -0700, David Brownell wrote:
Please merge.
Nice, I've applied this and will beat on it for a few days.
Thanks!
Oh, I removed one comment you added:
/* Decrement the reference count, it'll auto free everything when */ /* it hits 0 which could very well be now */ + /* FIXME the decrement in device_unregister() should suffice ... */ usb_put_dev(dev);
Not true at all. We need that last put_dev, as we called usb_get_dev in the top of usb_new_device().
Then the fix should then be to remove both of those, yes? The comment doesn't imply that's the only thing to change... :)
- Dave
thanks,
greg k-h
------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
