Greg KH wrote:

Any reason why you are using ioctls here and not just using the procfs
(and for 2.6, sysfs?)

ioctls will not be portable to other platforms unless you provide the
32-64 bit thunking layer, so no one with x86-64 boxes will be able to
use your driver.


'ovcamchip' is the i2c-kernel-driver for the i2c-adapter included in the w9968cf v4l1 driver, Typical I2C communication mechanism is used, no ioctls and kernel-userspace boundary crossing. Have a look at the ovcamchip _v2.25_ source code for more informations..



Hm, then what's the OVCAMCHIP_CMD_S_MODE ioctl definition for?



It is a pseudo-ioctl, which is called by kernel code only, using the normal i2c command() call. That's how V4L drivers communicate with i2c clients for tuners/decoders/etc... In this case, the V4L ioctl for setting up a video mode was not expressive enough, so I had to add a new one.


If this driver ever needs to be controlled using i2c-dev, I will either make sure that this code has the necessary thunking, or find another way to do it.

Why not
just export some functions that your add-on module can call?  That would
make things a lot easier I bet.


It wouldn't, since that would require the ovcamchip driver to be loaded whenever the V4L driver that uses it is loaded. AFAIK, all of the W996xCF cameras depend on ovcamchip so that is not a problem in this case, but for other drivers (e.g. ov511) ovcamchip is only needed with certain devices.


--
Mark McClelland
[EMAIL PROTECTED]




------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to