> Agreed. Any proposals on how to do it?
Still none, but here's a patch to kill the ioctls.
Regards
Oliver
You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.
===================================================================
[EMAIL PROTECTED], 2003-10-05 13:09:14+02:00, [EMAIL PROTECTED]
- remove ioctls incompatible with driver core
devio.c | 23 ++++-------------------
1 files changed, 4 insertions(+), 19 deletions(-)
diff -Nru a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
--- a/drivers/usb/core/devio.c Sun Oct 5 13:10:37 2003
+++ b/drivers/usb/core/devio.c Sun Oct 5 13:10:37 2003
@@ -1095,26 +1095,11 @@
retval = -EINVAL;
else switch (ctrl.ioctl_code) {
- /* disconnect kernel driver from interface, leaving it unbound. */
- /* maybe unbound - you get no guarantee it stays unbound */
- case USBDEVFS_DISCONNECT:
- /* this function is misdesigned - retained for compatibility */
- lock_kernel();
- driver = ifp->driver;
- if (driver) {
- dbg ("disconnect '%s' from dev %d interface %d",
- driver->name, ps->dev->devnum, ctrl.ifno);
- usb_unbind_interface(&ifp->dev);
- } else
- retval = -ENODATA;
- unlock_kernel();
- break;
-
- /* let kernel drivers try to (re)bind to the interface */
+ /* To be removed altogether in 2.7 */
+ case USBDEVFS_DISCONNECT:
case USBDEVFS_CONNECT:
- lock_kernel();
- retval = usb_probe_interface (&ifp->dev);
- unlock_kernel();
+ printk(KERN_WARNING "usbfs:This ioctl is no longer supported.\n");
+ retval = -ENOTTY;
break;
/* talk directly to the interface's driver */
===================================================================
This BitKeeper patch contains the following changesets:
1.2256
## Wrapped with gzip_uu ##
begin 664 bkpatch17465
M'XL(`"W\?S\``\646VO;0!"%G[6_8DA>[EMAIL PROTECTED],ZN+)067)+:3FA0GV$Y+H1!T
M65O"LM:L)(>"?GS7=DF:DH0V?:C0P["C/?OMF8,.X;82*C1DD6^$8H?P459U
M:.AZU:2B-$O1+)N5*=5"]R92ZIZ5R96P]ANLF1*BLJ)EW50QTY_<1'62@>Y4
MH4&F_;!2?U^+T)@,[EMAIL PROTECTED];T>BY>G:2,*<ZEDE&U/:Q_:
M+4<D(NZB[7KDMMRW;:<E#^-4ERGO!O/8"]B>Y_09\*=2-B&ZA`XZ7JLK!]D`
MR.3<]0!MB]!"[EMAIL PROTECTED],0C).48>(L++TG!,T$%V#O_.WV<)=$")E=P(R&52%Q7D
M92)7ZZC.XT+`?5YGD*HM"B12"78%Y".RFT<G6><O'\8P0O;A&?S]096EQVJE
M8I-+,WF\B(,!=5ORG:[?NGQ.8FYSBKG`F.Q7W'HBNKW"K\K[N1`&Z+;(G0!W
M(7EIQ_.9>3,T6RBQ.-T+:<M?!T6?/.HZONNW#O&`[P+DV[_'!]T_B(\#'0K^
M6WYV-E]#1]WO7IV'FQ<=?T.V!GJ:/I#'1IK?!LX,ZPAF$F+QDS.%J*CE0M29
M9LI+X&87CBQF)%$EX'9Z/AA^OIC>#4;3_O5X/.S/0BU)Y(*]4^QN%8VURLMZ
M^>YJ.!G??3F;C$?C2SC0\/,JG&5YM;<"=%%***2V5$'5K-=2U2(UOY4'[T^T
HB!+U)[EMAIL PROTECTED]'HV^WKR^"M+,I$LJV;5<W5"O8!\]@/8E7'),P4`````
`
end
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
