On Wed, Oct 29, 2003 at 05:05:28PM -0500, Alan Stern wrote: > > Why not to keep completion around in the structure? > > It's not cleared. It only gets used once, when the hub disconnect() > routine is called. Therefore there's no need to waste space allocating > the completion in the structure, when putting it on the stack will work > just as well.
Generally, stack space is precious, whereas a structure is virtually free (unless there are truly many of them, such as inodes or pages). That's why I'd make the judgement differently. However, I do not have a strong preference. The khubd is not engaged into filesystem activities, so it has plenty of stack (relatively speaking). -- Pete ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
