Greg, please apply this patch to 2.6.x This patch basically eliminates the use of MODE_SENSE or MODE_SENSE_10 for direct-access USB storage devices. That $&%*! command has caused us more trouble than all the others combined, and after more than a year we still don't have a good way of handling/using them.
I constantly get complaints about devices which don't work because of the
way 2.5/6 uses MODE_SENSE and MODE_SENSE_10 -- this patch will greatly
increase compatiblity with devices. As with the patch to limit transfer
sizes, I'd like to see this applied as soon as possible.
Matt
----- Forwarded message from Patrick Mansfield <[EMAIL PROTECTED]> -----
Date: Thu, 20 Nov 2003 08:28:27 -0800
From: Patrick Mansfield <[EMAIL PROTECTED]>
Subject: [PATCH] don't send any MODE SENSE commands to usb mass storage devices
To: [EMAIL PROTECTED]
Return-Path: <[EMAIL PROTECTED]>
X-Spam-Status: No, hits=1.0 required=5.0 tests=RCVD_IN_ORBZ version=2.11
Matthew -
Is this patch in your queue? I don't see it in Linus' tree yet.
Don't send any MODE SENSE commands to usb mass storage devices.
diff -uprN -X /home/patman/dontdiff bl-25/drivers/usb/storage/scsiglue.c
usb-ms-flags/drivers/usb/storage/scsiglue.c
--- bl-25/drivers/usb/storage/scsiglue.c Mon Oct 27 14:28:18 2003
+++ usb-ms-flags/drivers/usb/storage/scsiglue.c Fri Nov 14 09:15:20 2003
@@ -322,7 +322,8 @@ struct scsi_host_template usb_stor_host_
.emulated = TRUE,
/* modify scsi_device bits on probe */
- .flags = (BLIST_MS_SKIP_PAGE_08 | BLIST_USE_10_BYTE_MS),
+ .flags = (BLIST_MS_SKIP_PAGE_08 | BLIST_MS_SKIP_PAGE_3F |
+ BLIST_USE_10_BYTE_MS),
/* module management */
.module = THIS_MODULE
----- End forwarded message -----
--
Matthew Dharm Home: [EMAIL PROTECTED]
Maintainer, Linux USB Mass Storage Driver
C: Like the Furby?
DP: He gives me the creeps. Think the SPCA will take him?
-- Cobb and Dust Puppy
User Friendly, 1/2/1999
pgp00000.pgp
Description: PGP signature
