Pete Zaitcev wrote:

I have a couple of oops reports filed against RHL 9 & FC1,
which can be attributed to printer using:
 while (urb->status == -EINPROGRESS)
I see some lessons take a while to absorb. Fortunately,
2.6 is fixed in this regard, and this this backport.
Would someone test and let me know? I need someone with a WORKING
printer to run it and tell me if it continued to work.
The 2.6 works fine, but perhaps I missed something when diff-ing.


Just a quick remark,

In your patch (and in the original code too) "usblp_write" there is:

>  if (file->f_flags & O_NONBLOCK)
>    return -EAGAIN;

Shouldn't this be:

>  if (file->f_flags & O_NONBLOCK)
>    return writecount ? writecount : -EAGAIN;

or am I missing something?

Anyway, if this patch applies cleanly to 2.4.23-rc2, i'll try it as soon as I have some time.

Thanks for the fix,

--
Paulo Marques
Software Development Department - Restinfor, Lda.
Phone: +351 252 290600, Fax: +351 252 290601
Web: www.grupopie.com

"In a world without walls and fences who needs windows and gates?"



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to