This patch fixes some obvious errors in the jumpshot and datafab drivers. Greg, please apply.
This should close out Bugzilla bug #1408
Matt
----- Forwarded message from Alan Stern <[EMAIL PROTECTED]> -----
Date: Mon, 1 Dec 2003 12:14:53 -0500 (EST)
From: Alan Stern <[EMAIL PROTECTED]>
Subject: Patch from Eduard Hasenleithner
To: Matthew Dharm <[EMAIL PROTECTED]>
cc: USB Storage List <[EMAIL PROTECTED]>
X-Spam-Status: No, hits=1.2 required=5.0
tests=AWL,PATCH_UNIFIED_DIFF,RCVD_IN_OSIRUSOFT_COM,
SPAM_PHRASE_00_01,USER_AGENT_PINE,X_OSIRU_OPEN_RELAY
version=2.44
Matt:
Did you see this patch? It was posted to the usb-development mailing list
about a week ago, before I started making all my changes. It is clearly
correct and necessary.
Alan Stern
--- linux-2.6.0-test9/drivers/usb/storage/jumpshot.c.orig 2003-10-25
20:42:49.000000000 +0200
+++ linux-2.6.0-test9/drivers/usb/storage/jumpshot.c 2003-11-22 18:38:07.705653776
+0100
@@ -317,7 +317,7 @@
}
// read the reply
- rc = jumpshot_bulk_read(us, reply, sizeof(reply));
+ rc = jumpshot_bulk_read(us, reply, 512);
if (rc != USB_STOR_XFER_GOOD) {
rc = USB_STOR_TRANSPORT_ERROR;
goto leave;
--- linux-2.6.0-test9/drivers/usb/storage/datafab.c.orig 2003-10-25
20:44:53.000000000 +0200
+++ linux-2.6.0-test9/drivers/usb/storage/datafab.c 2003-11-22 18:37:53.793768704
+0100
@@ -387,7 +387,7 @@
// we'll go ahead and extract the media capacity while we're here...
//
- rc = datafab_bulk_read(us, reply, sizeof(reply));
+ rc = datafab_bulk_read(us, reply, 512);
if (rc == USB_STOR_XFER_GOOD) {
// capacity is at word offset 57-58
//
----- End forwarded message -----
--
Matthew Dharm Home: [EMAIL PROTECTED]
Maintainer, Linux USB Mass Storage Driver
It's not that hard. No matter what the problem is, tell the customer
to reinstall Windows.
-- Nurse
User Friendly, 3/22/1998
pgp00000.pgp
Description: PGP signature
