On Mon, Oct 27, 2003 at 05:50:13PM -0800, Matthew Dharm wrote: > Greg, this is a 2.5/6 patch -- please apply. The description is below. > > The residue update shouldn't make much of a difference, as almost nobody > checks that value. But, it is reported via sg, so it should be accurate. > > Matt > > ----- Forwarded message from Alan Stern <[EMAIL PROTECTED]> ----- > > Date: Fri, 24 Oct 2003 15:27:37 -0400 (EDT) > From: Alan Stern <[EMAIL PROTECTED]> > Subject: PATCH: (as119) Issue CBI clear_halt and fix BBB residue > To: Matthew Dharm <[EMAIL PROTECTED]> > cc: USB Storage List <[EMAIL PROTECTED]> > X-Spam-Status: No, hits=-5.0 required=5.0 tests=UNIFIED_PATCH version=2.11 > > Matt: > > This patch does 2 things (bad, I know -- but they're both pretty small > and pretty obscure). > > The CBI specification states in section 2.4.3.1.3 that > > ... the host shall also issue Clear Feature for Endpoint Halt > to the Bulk In pipe if the device reports that the Data In > command block has Failed. > > along with a note in section 2.5.3 that Data Out commands should work > analogously. This patch does that, along with cleaning up the status > detection logic a little. > > For Bulk-only transfers we currently ignore the dResidue field in the CSW, > except for reporting it (without byte-swapping!) in a debug message. The > patch uses it to compute the residue value returned to the SCSI layer. > Note that the Bulk-only spec allows devices to transfer more data than > they actually use (i.e., they may add padding or ignore stuff) and then > inform the host of this by means of the dResidue value. The logic used is > simple: our reported residue is the larger of what the device claims and > what we didn't transfer, except that it can't be larger than the total > transfer length.
Applied, thanks. greg k-h ------------------------------------------------------- This SF.net email is sponsored by: IBM Linux Tutorials. Become an expert in LINUX or just sharpen your skills. Sign up for IBM's Free Linux Tutorials. Learn everything from the bash shell to sys admin. Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
