Hi,
On Sat, Dec 27, 2003 at 07:24:11PM +0200, Petko Manolov wrote:
> Hi there,
>
> On Fri, 26 Dec 2003, Dimitri Torfs wrote:
>
> > "Chip" identification of the pegasus driver does not work correctly on
> > big endian machines, resulting in incorrect packet lengths for
> > received ethernet packets. These patches (against 2.4.24-pre2 and
> > 2.6.0) should fix it.
>
> Have you tried these patches by the way?
The 2.4.24-pre2 has been tested on a big endian MIPS machine. The 2.6.0
kernel doesn't run yet on my platform...
> > @@ -532,7 +532,7 @@
> > if (!count)
> > goto goon;
> >
> > - rx_status = le32_to_cpu(*(int *) (pegasus->rx_buff + count - 4));
> > + rx_status = le32_to_cpup((u32*)(pegasus->rx_buff + count - 4));
>
> I don't see how this makes any difference. Either way the result should
> be the same...
Indeed, this didn't make a difference. However, not all architectures
like dereferencing a u32* which is not properly aligned (hence the
le32_to_cpup macro). This particular change just makes the code more portable.
> happy holidays,
> Petko
Same to you,
Dimitri
--
Dimitri Torfs | NSCE
[EMAIL PROTECTED] | Sint Stevens Woluwestraat 55
tel: +32 2 2908451 | 1130 Brussel
fax: +32 2 7262686 | Belgium
-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills. Sign up for IBM's
Free Linux Tutorials. Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
