On Mon, 5 Jan 2004, Duncan Sands wrote:
> Well done! However one could say that the problem is in modem_run.
> The problem is that modem_run sets altsetting 1 on interface 1 then
> exits. pppoax expects to see that altsetting. But when modem_run
> exits it releases interface 1 which returns interface 1 to altsetting 0
> (thanks to a change by Alan Stern (IIRC)). Then pppoax is run.
> It needs altsetting 1 to work. I think the right solution is for pppoax
> to set altsetting 1 on interface 1 itself. Just remove the test
> if (alternate_ep != -1) {
> in pppoa3.c, line 680 (untested).
>
> Alan, what do you think? Is choosing altsetting 0 in usb_driver_release_interface
> appropriate given that there are user space drivers around?
I think we're doing the right thing. A user space driver shouldn't
assume, when it rebinds an interface, that the interface is still in the
same state as when it was unbound earlier. After all, another user space
driver might have interfered in the meantime. The only reasonable
assumption is that the interface is in its default altsetting 0 state,
which is what we do.
Alan Stern
-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills. Sign up for IBM's
Free Linux Tutorials. Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
