On Mon, 29 Dec 2003, David Brownell wrote:
How about using this approach instead? It simplifies the kconfig for the gadget drivers by providing a boolean "which hardware" symbol, so gadget drivers don't need to make their own. The symbol that's synthetic is the one needed only by the Makefile.
There are some strange things in there. choice values can also be tristate symbols, so you wouldn't need the separate defines, unless you really always want to compile only a single controller (even as module). The "default m if USB_GADGET = m" looks weird, if I understand them correctly this should just be "depends on USB_GADGET", e.g.
config USB_NET2280
tristate
depends on USB_GADGET
default USB_GADGET_NET2280this would also fix the menu structure and the drivers menu would appear below the gadget option. I'm also not sure about USB_PXA2XX_SMALL, as it also can be written as:
config USB_PXA2XX_SMALL
depends on USB_PXA2XX = y
default USB_ZERO = y || USB_ETH = y || USB_G_SERIALis this really intended?
The dependency "USB_DUMMY_HCD || USB_NET2280 || USB_PXA2XX || USB_SA1100 || USB_GOKU" can be basically reduced to "USB_GADGET".
Roman, this seems to trigger some kind of xconfig/menuconfig bug, since I can go down the list of hardware options (net2280, goku, dummy -- three, not the single one Adrian was working with) and each deselects the previous selection ... but then it's impossible to turn off the dummy, and select real hardware.
I can't reproduce this, it works fine here.
bye, Roman
------------------------------------------------------- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
