On Fri, Jan 16, 2004 at 02:54:50PM -0800, Greg KH wrote: > On Fri, Jan 16, 2004 at 02:47:10PM -0800, James Lamanna wrote: > > > > > > > >When creating a structure for an ioctl, you have to explicitly state how > > >big the different fields are. Use the '__' types. So for your case, > > >you probably want to use the "__u32" types. > > > > Ah. > > I guess I was following the example of struct hiddev_usage_ref. > > Maybe those in hiddev_usage_ref should also be changed to __u32? > > Probably should, but I'll let Vojtech rule on those :)
Let's do the type change. Regarding the _ref_multi patch - that one is OK, though I'd prefer to embed the hiddev_usage_ref struct into hiddev_usage_ref_multi - that way one can be sure no alignment issues will cause trouble in the cast from _ref_multi to _ref. And regarding the first patch - I'm still not convinced it's the right way to do it - James, can you send me a descriptor dump for that device? Maybe we're just misparsing the descriptor ... -- Vojtech Pavlik SuSE Labs, SuSE CR ------------------------------------------------------- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
