On Wed, 21 Jan 2004, David Brownell wrote: > Date: Wed, 21 Jan 2004 17:53:16 -0800 > From: David Brownell <[EMAIL PROTECTED]> > To: John Heil <[EMAIL PROTECTED]> > Cc: [EMAIL PROTECTED], [EMAIL PROTECTED], > linux-usb-devel <[EMAIL PROTECTED]> > Subject: Re: [linux-usb-devel] Re: Test of ehci iso patch > > John Heil wrote: > > > I looked back at my driver code and it does set each URB to > > URB_NO_INTERRUPT, however, in itd_fill I set the EHCI_ITD_IOC bit > > on the last transation of each iTD, thus overriding URB_NO_INTERRUPT > > Why would you want to force IRQ-per-iTD? Hmm, and I noticed that > the URB_NO_INTERRUPT is ignored in that latest patch. Minor bug, > see the appended patch.
Thanx. It was a quick-n-dirty, early on, when I was extending the core code to do 8 transactions per iTD, ... and... something I had forgotten about till I looked back. > > > > and presumably log2_irq_thresh=6 also, something I'll be cleaning > > up as I progress. > > No, the irq threshold is a global setting. You've got much finer > control by just submitting bigger URBs or hinting URB_NO_INTERRUPT. > > - Dave Good, I'll pull it see what happens. > > > --- 1.29/drivers/usb/host/ehci-sched.c Sun Dec 28 21:09:07 2003 > +++ edited/ehci-sched.c Wed Jan 21 17:51:46 2004 > @@ -718,7 +718,8 @@ > > trans = EHCI_ISOC_ACTIVE; > trans |= buf & 0x0fff; > - if (unlikely ((i + 1) == urb->number_of_packets)) > + if (unlikely (((i + 1) == urb->number_of_packets)) > + && !(urb->transfer_flags & URB_NO_INTERRUPT)) > trans |= EHCI_ITD_IOC; > trans |= length << 16; > uframe->transaction = cpu_to_le32 (trans); > - ----------------------------------------------------------------- John Heil South Coast Software Custom systems software for UNIX and IBM MVS mainframes 1-714-774-6952 [EMAIL PROTECTED] http://www.sc-software.com ----------------------------------------------------------------- ------------------------------------------------------- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
