USB hci interface's probably will not work with shared IRQ without this patch. The hcd core always returns IRQ_HANDLED.
Actually they do work, but whatever corner cases motivated the irqreturn_t change clearly won't. (Mostly detecting IRQ lines that are wedged.)
The problem with returning handled is that the next irq in the chain
doesn't get called. None of my machines share USB irq, but some
share IRQ between network and serial. And if the network card
always returns handled then the serial doesn't work; therefore I notice when other drivers have the same problem.
Well, they still work in some (evidently common) configurations. The system I'm using to type this has an apallingly stupid BIOS that shares IRQ 11 between pretty much everything.
This would seem unrelated to the main IRQ-related problem I know about for the USB stack: PCI IRQ misconfiguration, so USB HCs never get any interrupts.
Though I do wonder about the OHCI code returning IRQ_NONE for the case of a cardbus eject ("device removed"). That doesn't seem right, and it doesn't match your change to the EHCI driver.
I am not really sure what the correct response is in the device removed case. Some drivers return NONE and some return handled.
By returning NONE you're preventing some cleanup logic from running, just for OHCI. I do think those two drivers should be consistent, choosing only one of:
(a) NONE and expect "pccardd" to gracefully shut everything down;
(b) HANDLED to get the behavior they've been using so far, with
"keventd" disconnecting.A lot changed in 2.5, but in about the 2.4.18 era it seemed that the pcmcia/cardbus framework wouldn't shut things down; so that's why USB now uses (b). Worth revisiting option (a) along with the other reset/disconnect path updates that are in the works.
- Dave
I think this'd be OK for Greg to merge if you changed that bit.
------------------------------------------------------- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
