Hi Greg,
if submission of the interrupt URb fails in belkin_sa_open() the
previously submitted URB may remain live. The rest of the system
thinks that opening failed, therefore the URB should be unlinked
in the error case.
Regards
Oliver
You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.
===================================================================
[EMAIL PROTECTED], 2004-01-31 23:12:31+01:00, [EMAIL PROTECTED]
- fix resources leak in an error case
belkin_sa.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletion(-)
diff -Nru a/drivers/usb/serial/belkin_sa.c b/drivers/usb/serial/belkin_sa.c
--- a/drivers/usb/serial/belkin_sa.c Sat Jan 31 23:18:25 2004
+++ b/drivers/usb/serial/belkin_sa.c Sat Jan 31 23:18:25 2004
@@ -232,8 +232,10 @@
port->interrupt_in_urb->dev = port->serial->dev;
retval = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL);
- if (retval)
+ if (retval) {
+ usb_unlink_urb(port->read_urb);
err(" usb_submit_urb(read int) failed");
+ }
exit:
return retval;
===================================================================
This BitKeeper patch contains the following changesets:
1.1159
## Wrapped with gzip_uu ##
begin 664 bkpatch15774
M'XL(`+$I'$```[64;6_3,!#'7\>?XJ2]V822^.RD:8(ZC6T($$A,A;U":'*3
M:VLUB2?;&2#"=\?MI`T$;`,-QU(>[B'WO_LE>W#NR%:1:?456;8'+XWS512N
MNZ&A/NEIV`Q=8NPJV.;&!%NZ-AVEUP'I>TODTE;[EMAIL PROTECTED]/@=:[EMAIL PROTECTED]
MB;QYXK]<4A7-G[\X?_-LSMAL!B=KU:_H'[EMAIL PROTECTED]:/O%6]:XC
MKY+:[EMAIL PROTECTED]'(L9`\GXPXX5DQUM@@[EMAIL PROTECTED];3C)V7=[1;W3\G"KC*!%+
M44@<,U%RR4X!$\2\!)ZE'%.)(&2%HI+XA&/%.?PY-3Q!B#D[AL?5<L)JB&&I
M/X,E9P9;DX.6U`9T#ZH'LM98J)4C]AHRR;,I.[MM+8O_<C'&%6>']VAH[+8)
M+AW<(@T`:=6F"VHWNK]PP>$'8:'!Q2B"0#%B691(*EN4S434T[LZ^8#\N\D)
M$;8<,YYSW"%U=]S]G#V&+A8BVJ%NU)'7KE:M3K3_L+*T^OB`]))/Q79->3;*
M`J78`2E_P5'(!^`H(<;_A./0AX]^$ZBTSL/[EMAIL PROTECTED](YJ
MTS>P5+IU6SIW<WH+L?VTVX&VLWM&[EMAIL PROTECTED]@J9`[)[EMAIL PROTECTED](/'3B`KRR*
MPGLNKJN_&.QB_])8'Q]:4LWV]N#I-FX2PJ-OMS^S>[EMAIL PROTECTED];$)-4>14LN^V
'WF&U.`4`````
`
end
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
