[Message didn't make it to the list because of an incorrect address] On Fri, 6 Feb 2004, Stephen Hemminger wrote:
> > Can you isolate and break out the single ingredient responsible for the > > deadlock you were experiencing? > > Yes, the list management with remove lists and multiple locks was crap. > The rest was just the fall out from that change. I should have been more explicit. I meant: Can you provide an explanation of what caused your deadlock, more detailed than just "the list management was crap"? Can you point to exactly what in the code went wrong, and can you provide a minimal patch to fix it, remaining in the context of the current crappy lists and locks? It's not that I'm not interested in your work; quite the opposite. However a large patch like the one you sent, which restructures many of the key internal workings of the driver, would never get accepted. Greg would insist at a minimum on having it broken up into pieces, each of which did just one of the things you listed. Furthermore, sweeping changes like yours are less likely to be accepted during a stable kernel series. For some of the changes you made, I doubt they will be allowed in the kernel before 2.7 starts up. But please save what you wrote. Try to break it up into smaller simpler changes. I will want you to resubmit it. Some of the things, like switching over to the standard <list.h> idioms, should have no trouble getting into 2.6. Next week, if you're interested, I'll send you a list I've compiled of about 25 changes the UHCI driver needs. (It's not on this computer here.) Some of the items overlap with what you wrote. The <list.h> stuff was something I had intended to include but it slipped my mind later on. Other changes you made were things I hadn't thought of, but they all look worthwhile. Should you feel like continuing to work on the driver, this will give you a good set of things to do. Alan Stern ------------------------------------------------------- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
