David:
Is there a reason why usb_hcd_pci_resume() doesn't call pci_set_master() and makes the HC drivers do it instead?
Well, for one thing the suspend() logic doesn't disable bus mastering; such asymmetries tend to be bug-prone. Mostly I think that's just how it happened, and I'm not sure anyone's really looked at those issues closely.
I'm not sure about what the right division of responsibility should be there. For PCI, I think most of the logic should be boilerplate. But it seems that some ASICs (maybe including old Apple pbooks) need ASIC-specific resume hooks ... and if they don't have a better home in the device model, they might need to get pushed into some HCDs (before PCI hooks).
I've not dared try PM suspend/resume recently, since the drivers/base/power bug I reported ages ago is still open. (Devices can't be removed while resuming.)
- Dave
------------------------------------------------------- SF.Net is sponsored by: Speed Start Your Linux Apps Now. Build and deploy apps & Web services for Linux with a free DVD software kit from IBM. Click Now! http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
