On Sun, 22 Feb 2004, Matthew Dharm wrote:

> So, many people have complained about the warning message that usb-storage
> gives.  It really wasn't very good.
> 
> How does this strike people?  At this point, I'm looking for comments (not
> to have this applied).
> 
> Of course, this assumes that someone does add something to the FAQ.
> 
> Matt
> 
> ===== drivers/usb/storage/usb.c 1.113 vs edited =====
> --- 1.113/drivers/usb/storage/usb.c   Wed Feb 11 23:57:02 2004
> +++ edited/drivers/usb/storage/usb.c  Sun Feb 22 16:38:22 2004
> @@ -954,9 +954,9 @@
>       scsi_scan_host(us->host);
>  
>       printk(KERN_DEBUG 
> -            "WARNING: USB Mass Storage data integrity not assured\n");
> -     printk(KERN_DEBUG 
>              "USB Mass Storage device found at %d\n", us->pusb_dev->devnum);
> +     printk(KERN_DEBUG 
> +            "WARNING: umount before removing USB device -- read the FAQ\n");
>       return 0;
>  
>       /* We come here if there are any problems */

This strikes me as a lot clearer and less susceptible to misinterpretation
than the original.  Maybe you could include a URL for the FAQ; otherwise
people might not know what FAQ it refers to.

Alan Stern



-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to