On Mon, 23 Feb 2004, Stephen Hemminger wrote:
> Bulk and interrupt urb's share common irq processing, why does the
> code try to obfuscate it?
Quite right; this is needless complexity. (But note you left in a couple
of lines that should have been deleted.)
Greg, this is a trivial obviously-correct patch. Please apply.
Alan Stern
===== uhci-hcd.c 1.92 vs edited =====
--- 1.92/drivers/usb/host/uhci-hcd.c Mon Feb 23 12:15:56 2004
+++ edited/drivers/usb/host/uhci-hcd.c Tue Feb 24 10:15:52 2004
@@ -1271,12 +1271,6 @@
}
/*
- * Bulk and interrupt use common result
- */
-#define uhci_result_bulk uhci_result_common
-#define uhci_result_interrupt uhci_result_common
-
-/*
* Isochronous transfers
*/
static int isochronous_find_limits(struct uhci_hcd *uhci, struct urb *urb, unsigned
int *start, unsigned int *end)
@@ -1537,11 +1531,9 @@
case PIPE_CONTROL:
ret = uhci_result_control(uhci, urb);
break;
- case PIPE_INTERRUPT:
- ret = uhci_result_interrupt(uhci, urb);
- break;
case PIPE_BULK:
- ret = uhci_result_bulk(uhci, urb);
+ case PIPE_INTERRUPT:
+ ret = uhci_result_common(uhci, urb);
break;
case PIPE_ISOCHRONOUS:
ret = uhci_result_isochronous(uhci, urb);
-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
