Greg KH wrote: > On Wed, Feb 25, 2004 at 08:25:00PM +0100, Juergen Stuber wrote: > > It's the same, and actually __func__ is standard as of C99, > > __FUNCTION__ is an older gcc extension. > > But if you do that, you break building with older versions of gcc, which > we still must support. So please do not change these, the gcc people > have already changed the way __FUNCTION__ works once in the past, we > don't want to go back and change everything again...
Ok, I'll also fix that back to __FUNCTION__ in legousbtower. > > +static size_t buffer_size = 1024; > > +MODULE_PARM(buffer_size, "i"); > > +MODULE_PARM_DESC(buffer_size, "Maximal USB transfer size"); > > This is a device specific thing. Let's leave that up to the individual > driver author and not mess with the skeleton driver. The point is to show the author that he can mess with it, it took me a while to get that when I started. > It's way too big anyway... Well, in USB 2.0 bulk packets can be 512 byte, and this is the next bigger power of 2. And for large bulk transfers I've seen people use buffers of 8 or 16K (at 12MBit/s). > > +static loff_t skel_llseek (struct file *file, loff_t off, int whence); > > Why? You don't even do anything with this? Why would you call lseek on > a char device anyway? It's not needed. This is recommended in the Linux Device Drivers book for drivers that don't support seeking (http://www.xml.com/ldd/chapter/book/ch05.html#t5). Though they might be a bit overzealous, I don't know. J�rgen -- J�rgen Stuber <[EMAIL PROTECTED]> http://www.loria.fr/~stuber/ ------------------------------------------------------- SF.Net is sponsored by: Speed Start Your Linux Apps Now. Build and deploy apps & Web services for Linux with a free DVD software kit from IBM. Click Now! http://ads.osdn.com/?ad_id56&alloc_id438&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
