Hi,
you forgot to drop a spinlock before you report an error. A deadlock
will occur.
Regards
Oliver
You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.
===================================================================
[EMAIL PROTECTED], 2004-03-08 03:45:19+01:00, [EMAIL PROTECTED]
- fix locking in error case
pid.c | 1 +
1 files changed, 1 insertion(+)
diff -Nru a/drivers/usb/input/pid.c b/drivers/usb/input/pid.c
--- a/drivers/usb/input/pid.c Mon Mar 8 03:52:14 2004
+++ b/drivers/usb/input/pid.c Mon Mar 8 03:52:14 2004
@@ -200,6 +200,7 @@
break;
if ( id == FF_EFFECTS_MAX) {
+ spin_unlock_irqrestore(&pid_private->lock,flags);
// TEMP - We need to get ff_effects_max correctly first: || id >=
dev->ff_effects_max) {
dev_dbg(&pid_private->hid->dev->dev, "Not enough device
memory\n");
return -ENOMEM;
===================================================================
This BitKeeper patch contains the following changesets:
1.1169
## Wrapped with gzip_uu ##
begin 664 bkpatch14064
M'XL(`-[?2T```\64[XO3,!C'7S=_Q0,'HIQK\_3'NE5V3,]#1<%Q>J]$CBQ]
MUM;KDIFD-Y7^\:8;W"&Z@:+8M!#R)-]^G^?YD!.XLF2*0+?-+1EV`B^U=47@
MY^NN)!4JZFZZ=:A-Y6.76OM85.LU1?L#T7M#9*.V49T=Q6'&_*Z%<+(&'[1%
M@&%RM^*^;J@(+B]>7+UY>LG8;`;GM5`5O2,'LQESVMR*MK1SX>I6J]`9H>R:
MG`BE7O=W6_N8\]B/#/.$9^,>QSS->XDEHDB12AZGDW'*]O;FO\CC1ZF4)SQ%
MGO$DZQ$G6<*>`X:(XRGP-.))Q"?`DR+-"IR><BPXA\/2<(HPXNP9_-U<SIF$
M$:R:+]!J>=.H"AH%9(PV((4E]AHPYCAFB_N"LM%O/HQQP=D9W.I/CF0]=]NF
M;:K:A9W<AO);7YHA:1MU=ADU:M.Y:-.4H=QGD"-BAC%F?>PKE_9Y0D+&JW*)
M93F>)-,C)3LF//1FXFN0\;S'/,?)#IH#!P:$_HEYMI2Z]8#;>4G+1JC!]8?*
M4/7QF*[O9\+]EPUMC0>9@:N?H.+Y_X6J-'JSHPJ6M-*&P)[EMAIL PROTECTED]
MOV9U9R39@;1=']["R&QWKR=G<:@E?P#A*^\<D`5!8#>-NN[4X.VZ,9^]!Y\_
M/[EMAIL PROTECTED]:\W_G_"T>ALB#Y>M:*RCY[<7SVR)GECN_6,IR+.Y)38=T=U\5SF!```
`
end
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
